Skip to content

update Python to 3.9.2#2337

Closed
obfusk wants to merge 1 commit into
kivy:developfrom
obfusk:python3.9
Closed

update Python to 3.9.2#2337
obfusk wants to merge 1 commit into
kivy:developfrom
obfusk:python3.9

Conversation

@obfusk

@obfusk obfusk commented Oct 17, 2020

Copy link
Copy Markdown
Contributor

My webview app seems to work fine w/ 3.9.0.

Since the 3.8.1 patches seem to work fine with 3.9.0 I decided not to rename/duplicate them (for now).

@inclement

Copy link
Copy Markdown
Member

Thanks @obfusk, we'd better do some testing first but that sounds good.

syleishere
syleishere previously approved these changes Dec 1, 2020

@syleishere syleishere left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve this

@syleishere

syleishere commented Dec 2, 2020

Copy link
Copy Markdown

OK I got around to testing obfusk's patch, something still needs patching:
TEST SETUP AS FOLLOWS:

Python 3.8 buildozer test with obfusk's patches:
buildozer.spec: (relevant lines for testing helloworld from kivy site)

requirements = python3==3.8.6,hostpython3==3.8.6,kivy==2.0.0rc4,https://github.com/kivymd/KivyMD/archive/master.zip,pygments,sdl2_ttf==2.0.15
#obfusk's patches
p4a.source_dir = %(source.dir)s/../python-for-android

RESULTS from logcat on Pixel 4 XL: (PASS)
http://sunsaturn.com/kivy/3.8.txt


Python 3.9 buildozer test with obfusk's patches:
buildozer.spec: (relevant lines for testing helloworld from kivy site)

requirements = python3==3.9.0,hostpython3==3.9.0,kivy==2.0.0rc4,https://github.com/kivymd/KivyMD/archive/master.zip,pygments,sdl2_ttf==2.0.15
#obfusk's patches
p4a.source_dir = %(source.dir)s/../python-for-android

RESULTS from logcat on Pixel 4 XL: (FAIL)
http://sunsaturn.com/kivy/3.9.txt

Additional comments: only thing that affects it failing is (python3==3.9.0,hostpython3==3.9.0) after running numerous tests with different modules like kivymd or just setting python3==3.9.0,hostpython3==3.9.0,kivy==2.0.0rc4 only in requirements line.
As you can see from logs, kivy is not getting loaded for some reason

@obfusk

obfusk commented Dec 3, 2020

Copy link
Copy Markdown
Contributor Author

@syleishere that is a bug in kivy.

Also: it would have been easier to diagnose that if you had also provided build logs 😄

@obfusk

obfusk commented Dec 3, 2020

Copy link
Copy Markdown
Contributor Author

With the proposed kivy patch, a simple "hello world" p4a kivy app seems to work fine now.

@obfusk

obfusk commented Dec 30, 2020

Copy link
Copy Markdown
Contributor Author
  • fixed merge conflict after changes to develop
  • updated Python to 3.9.1 (since that has been working fine for me)

@obfusk obfusk mentioned this pull request Jan 1, 2021
@obfusk obfusk mentioned this pull request Jan 2, 2021
@obfusk obfusk changed the title support Python 3.9 & update Python to 3.9.0 update Python to 3.9.2 Mar 5, 2021
@obfusk

obfusk commented Mar 5, 2021

Copy link
Copy Markdown
Contributor Author

Updated to python 3.9.2 (which has been working fine for me, but AFAIK still requires master for kivy apps).

@obfusk

obfusk commented Mar 5, 2021

Copy link
Copy Markdown
Contributor Author

If updating to 3.9 is still not desirable yet, may I suggest at least updating to 3.8.8 to get the latest (security) fixes?

I'd be happy to make a PR for that. I haven't tested it myself though, since I've been using 3.9.2.

@AndreMiras

Copy link
Copy Markdown
Member

Yes please go ahead with the security fixes patch version

@obfusk

obfusk commented Apr 25, 2021

Copy link
Copy Markdown
Contributor Author

Yes please go ahead with the security fixes patch version

See #2451.

@misl6

misl6 commented Jul 14, 2022

Copy link
Copy Markdown
Member

Closing as #2586 introduced Python 3.9.9, which is newer than the version proposed in this PR.

@misl6 misl6 closed this Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants