modifications for ndk >= r22#2393
Closed
obfusk wants to merge 1 commit into
Closed
Conversation
obfusk
force-pushed
the
ndk-22
branch
10 times, most recently
from
379687a to
3583f21
Compare
Contributor
Author
|
[edit: fixed] |
Contributor
Author
|
It "works for me" 😅 and I don't think these modifications would impact anyone not using ndk >= r22 (which doesn't work without these changes anyway), so I think this can be merged (assuming CI agrees with me). Adding a CI run w/ ndk r22 would be nice though. |
* ndk >= r22 no longer supports
- {ndk_dir}/platform
- {ndk_dir}/sysroot
* add & use
- ctx.ndk_standalone
- ctx.ndk_sysroot
- ctx.ndk_lib_dir
- ctx.ndk_include_dir
* patch openssl
* add FIXMEs to some recipes
- nothing should have changed for ndk < r22
- modifications and/or testing may be needed for ndk >= r22
* CI: mark some packages as broken
obfusk
changed the title
Contributor
Author
|
CI was happy, so I rebased & squashed. |
Contributor
Author
|
I'd appreciate some feedback on this (if someone has the time) :) |
Member
|
Can you confirm that with latest |
Member
|
NDK 23b is now the default supported version, I'm closing this PR as is now outdated. Maybe you would like to try the latest changes on Thank you for taking care of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2391