Skip to content

Fix ImportError bug: cannot locate symbol "modf"#2445

Merged
inclement merged 2 commits into
kivy:developfrom
Neizvestnyj:patch-4
Apr 5, 2021
Merged

Fix ImportError bug: cannot locate symbol "modf"#2445
inclement merged 2 commits into
kivy:developfrom
Neizvestnyj:patch-4

Conversation

@Neizvestnyj

Copy link
Copy Markdown
Contributor

Fix this bug ImportError: dlopen failed: cannot locate symbol "modf"
kivy/buildozer#1020

@inclement

Copy link
Copy Markdown
Member

Seems reasonable, thanks, but I think it should ideally be in LDFLAGS.

@Neizvestnyj

Copy link
Copy Markdown
Contributor Author

Seems reasonable, thanks, but I think it should ideally be in LDFLAGS.

do you mean so? env ['LDFLAGS'] + = f ' -lm'

@inclement

Copy link
Copy Markdown
Member

Yes, but no need to make this one a format string, skip the f.

That said, looking at the recipe it looks like it uses env['LIBS'] for this a few lines above. Could you check adding -lm in that line works?

@Neizvestnyj

Neizvestnyj commented Apr 4, 2021

Copy link
Copy Markdown
Contributor Author

Yes, but no need to make this one a format string, skip the f.

That said, looking at the recipe it looks like it uses env['LIBS'] for this a few lines above. Could you check adding -lm in that line works?

Hmm and really, it should work, should I build a package using this recipe and then create a new pull request?

@tshirtman

Copy link
Copy Markdown
Member

you could update this pull request instead of creating a new one, but aside that, yes.

@Neizvestnyj

Copy link
Copy Markdown
Contributor Author

@tshirtman @inclement I did a test build, everything works

@inclement inclement left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks.

@inclement inclement merged commit 6ab4bda into kivy:develop Apr 5, 2021
@Neizvestnyj Neizvestnyj deleted the patch-4 branch April 6, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants