Move PythonActivityUtil.unpackData to PythonUtil.unpackData#2462
Conversation
|
I haven't investigated why the tests are failing. |
|
looks like travis reached some limit, all other tests are sane now |
|
one question is whether we should remove PythonActivityUtil entirely since it's not used any more in bootstraps or keep for B/C in case someone depends on it in possible customizations. |
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
Thanks for the PR, LGTM.
I'd indeed remove the PythonActivityUtil if it's not used
|
Removed PythonActivityUtil. Two tests on travis are failing with docker pull rate limit, so probably unrelated. All other tests are fine. |
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
LGTM thanks
Ideally I like PR with squashed commits, but I think that's a matter of taste.
Will try to think to squash upon merge
2 participants
Consolidates unpackData for use outside activity context.