Skip to content

✅ Fix test_get_dep_names_of_package#2979

Merged
AndreMiras merged 1 commit into
kivy:developfrom
AndreMiras:feature/test_get_dep_names_of_package
Mar 7, 2024
Merged

✅ Fix test_get_dep_names_of_package#2979
AndreMiras merged 1 commit into
kivy:developfrom
AndreMiras:feature/test_get_dep_names_of_package

Conversation

@AndreMiras

Copy link
Copy Markdown
Member

Recent pythonf-for-android release added setuptools to install_requires. Pinning to previous release fixes to test.

The error was:

    def test_get_dep_names_of_package():
        # TEST 1 from external ref:
        # Check that colorama is returned without the install condition when
        # just getting the names (it has a "; ..." conditional originally):
        dep_names = get_dep_names_of_package("python-for-android")
        assert "colorama" in dep_names
>       assert "setuptools" not in dep_names
E       AssertionError: assert 'setuptools' not in {'Jinja2', 'appdirs', 'build', 'colorama', 'packaging', 'setuptools', ...}
tests/test_pythonpackage_basic.py:90: AssertionError

Recent pythonf-for-android release added setuptools to install_requires.
Pinning to previous release fixes to test.

The error was:
```
    def test_get_dep_names_of_package():
        # TEST 1 from external ref:
        # Check that colorama is returned without the install condition when
        # just getting the names (it has a "; ..." conditional originally):
        dep_names = get_dep_names_of_package("python-for-android")
        assert "colorama" in dep_names
>       assert "setuptools" not in dep_names
E       AssertionError: assert 'setuptools' not in {'Jinja2', 'appdirs', 'build', 'colorama', 'packaging', 'setuptools', ...}
tests/test_pythonpackage_basic.py:90: AssertionError
```
@AndreMiras AndreMiras merged commit 5d61bdb into kivy:develop Mar 7, 2024
@AndreMiras AndreMiras deleted the feature/test_get_dep_names_of_package branch March 7, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant