Skip to content

Add hardware acceleration codecs to ffmpeg recipe#3092

Merged
AndreMiras merged 5 commits into
kivy:developfrom
autosportlabs:bump_recipes_version_av
Dec 13, 2024
Merged

Add hardware acceleration codecs to ffmpeg recipe#3092
AndreMiras merged 5 commits into
kivy:developfrom
autosportlabs:bump_recipes_version_av

Conversation

@brentpicasso

@brentpicasso brentpicasso commented Dec 13, 2024

Copy link
Copy Markdown
Contributor

No description provided.

AndreMiras
AndreMiras reviewed Dec 13, 2024
View reviewed changes

@AndreMiras AndreMiras left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the title is misleading, it says bump recipes version, but all I see are the hardware acceleration codecs enabled right? I imagine the bump was reverted in subsequent commits.
Having the PR rebased & squashed would be a real plus, otherwise no worry I can try to think about it at merge time.
image

@brentpicasso brentpicasso changed the title Bump recipes version av Add hardware acceleration codecs Dec 13, 2024
@brentpicasso

brentpicasso commented Dec 13, 2024

Copy link
Copy Markdown
Contributor Author

@AndreMiras I think the original work was to bump the recipe versions, and also to add these codecs.

It seems that develop received these updated versions, and this PR left behind only the hardware codecs. @DexerBR do you agree with this assessment?

I updated the title to match the new reality.

@DexerBR

DexerBR commented Dec 13, 2024

Copy link
Copy Markdown
Contributor

@AndreMiras I think the original work was to bump the recipe versions, and also to add these codecs.

It seems that develop received these updated versions, and this PR left behind only the hardware codecs. @DexerBR do you agree with this assessment?

I updated the title to match the new reality.

I agree, the versions have been updated in this PR: #3065

@brentpicasso How about updating the title to "Add hardware acceleration codecs to ffmpeg recipe"?

@brentpicasso brentpicasso changed the title Add hardware acceleration codecs Add hardware acceleration codecs to ffmpeg recipe Dec 13, 2024
@brentpicasso

brentpicasso commented Dec 13, 2024

Copy link
Copy Markdown
Contributor Author

@brentpicasso How about updating the title to "Add hardware acceleration codecs to ffmpeg recipe"?

@DexerBR done!

@AndreMiras AndreMiras merged commit 37d272c into kivy:develop Dec 13, 2024
@brentpicasso brentpicasso deleted the bump_recipes_version_av branch December 13, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndreMiras AndreMiras AndreMiras approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brentpicasso @DexerBR @AndreMiras