Implemented wrapper corresponding to tick_params in matplotlib#143
Closed
belre wants to merge 2 commits into
Closed
Implemented wrapper corresponding to tick_params in matplotlib#143belre wants to merge 2 commits into
belre wants to merge 2 commits into
Conversation
lava
requested changes
Nov 19, 2019
lava
left a comment
lava
left a comment
Owner
There was a problem hiding this comment.
Hey, this looks pretty good, but isn't a
safe_import(s_python_function_tick_params);
missing? Otherwise it looks like the program should crash as soon as the new function is called.
belre
commented
Nov 19, 2019
lava
approved these changes
Nov 28, 2019
Owner
|
Merged, thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been developing VS2017 C++ dll using matplotlib-cpp.
I needed to change some rows of source code in order to adjust whole graph-plotting layouts, especially font size and margin in graph area.
So, I confirmed those in Windows 10 and no problems.
I tested those in static-link(VS2017) and in dynamic-link(called by JVM[JRE 8] ) and used Python 3.6(32bit).
Could you merge those code?
Users will feel more profits in that change.