Skip to content

Whitespace, than backslash compile fix#89

Open
gtgt wants to merge 1 commit into
leproxy:mainfrom
gtgt:88-ws-bs-compile-fix
Open

Whitespace, than backslash compile fix#89
gtgt wants to merge 1 commit into
leproxy:mainfrom
gtgt:88-ws-bs-compile-fix

Conversation

@gtgt

@gtgt gtgt commented Jul 13, 2023

Copy link
Copy Markdown

Better not to remove whitespace if followed by backslash.

Fixes #88

Better not to remove whitespace if followed by backslash.

Fixes leproxy#88
@SimonFrings

Copy link
Copy Markdown
Contributor

@gtgt Thanks for creating this pull request 👍

The description you provided doesn't really say much about the reason for your suggested changes, can you go a bit more into detail on why you want to change this?

Additionally, this pull request doesn't touch any of the tests, but I think we need some adjustments or some additional tests in order to confirm that your change works as expected. The test suite is currently failing and needs some adjustments as I described in #90 and #88, so in order to get the checks in here green, we'll first have to take a look at updating our test suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in running leproxy-0.2.2.php downloaded from release page

2 participants