Shallow support#4331
Open
tiennou wants to merge 10 commits into
Open
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhance our shallow object support in the following ways :
GIT_ENOTFOUND).Supersedes #3853, depends on #4445 and #4446.
This PR adds graft support at the ODB layer, withgit_repositorybeing responsible for tellinggit_odbabout known grafts. Shallow object support is then grafted (heh) on top of that.Notes :
- I'm not that convinced that having grafts at the ODB layer makes sense. FWIW, the crux of the issue is that object parsing is not done when objects are returned by the ODB, but by the caller (usually theobjectparse machinery, butrevwalkalso perform crude parsing for obvious reasons).gitdoes) is to have grafts be "transparent". IMHO, reporting an error in that case might help in the following cases :GIT_ENOTFOUND.GIT_EITEROVERif I don't actually care).