Disable SSL/TLS client certificate handling in WinHTTP.#4787
Closed
achidlow wants to merge 1 commit into
Closed
Conversation
This allows connecting to servers that ask for a client cert but don't require one.
Member
|
I'd be very happy to explicitly disable client certificates - it looks like the unit tests are not passing, however. Might we need to do this at a different point in the lifecycle of the connection? |
Member
|
Although I think that this change (as described) might make sense, it appears that this code is not quite right. Regrettably, I'm closing this PR for now since there's been no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can see there is currently a feature request #4204 for actually being able to supply a client certificate, however this change is still an incremental improvement over the current situation where there is no possible way to connect to a server that asks for an optional client certificate.
Code is basically straight from Microsoft docs: https://docs.microsoft.com/en-us/windows/desktop/winhttp/ssl-in-winhttp#optional-client-ssl-certificates