object: rename git_object__size to git_object_size#5118
Conversation
We don't use double-underscores in the public API.
|
I guess I'm a bit late to this, but should this even be public API? Could we rename it to make it clearer that it's not the size of the object itself but of our structure to hold the data? I went in today expecting |
🤷♂ Yeah, looking at it, I don't know why it's public. |
|
Now would be a good time to fix this since we haven't had a release that does anything here. If you wanted to roll the rename back and just deprecate |
|
I can be useful if you're really trying to account for memory usage from objects accurately (since this is on top of the actual inflated object). But even then, you don't necessarily know how many objects are cached anyway. So yeah, I think removing it is probably the best option at this point. |
In #5118 we remove the double-underscore to make it a normally-named public function. However, this is not an interesting function outside of the library and it takes up a name for something that could be more useful. Remove the single-underscore version as we have not done any releases with it.
In #5118 we remove the double-underscore to make it a normally-named public function. However, this is not an interesting function outside of the library and it takes up a name for something that could be more useful. Remove the single-underscore version as we have not done any releases with it.
3 participants
We don't use double-underscores in the public API.