CMake pkg-config modulification#5206
Merged
Merged
Conversation
pks-t
reviewed
Aug 23, 2019
pks-t
left a comment
pks-t
left a comment
Member
There was a problem hiding this comment.
I like this quite a lot. As you said, Requires.private is still missing, but apart from that it already looks quite nice to me. Does this also handle paths with spaces correctly, e.g. for the prefix or linker flags?
tiennou
force-pushed
the
cmake/pkgconfig-building
branch
from
e9a076a to
564b3ff
Compare
Contributor
Author
|
Okay, I've added some quoting in the hope that would be sufficient 😉. I've updated the gist with an OpenSSL, non-PCRE run, as a syntax check. |
pks-t
approved these changes
Sep 19, 2019
Member
|
Tried it on my own system and everything looked good to me. Thanks a lot, @tiennou! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the CMake module I wrote for mbedTLS, which tries to streamline writing
pkg-configfiles, in an attempt to fix #5203.This is incomplete (I think), but I'll need guidance, because macOS usually doesn't really care about *.pc files anyways.
Here's a gist of the current changes introduced, at least on macOS. I do think the
Libs.privatelooks "saner", but theRequires.privateisn't there yet.