refs: unlock unmodified refs on transaction commit#5264
Merged
Conversation
Contributor
Author
|
Btw, would be good to have this released together with #5257 because the working locks could lead to running into this issue more frequently. |
pks-t
requested changes
Oct 17, 2019
pks-t
left a comment
pks-t
left a comment
Member
There was a problem hiding this comment.
Thanks for this pull request! Looks good to me, except for the missing error check
Refs which are locked in a transaction without an altered target, still should to be unlocked on `git_transaction_commit`. `git_transaction_free` also unlocks refs but the moment of calling of `git_transaction_free` cannot be controlled in all situations. Some binding libs call `git_transaction_free` on garbage collection or not at all if the application exits before and don't provide public access to `git_transaction_free`. It is better to release locks as soon as possible.
pks-t
approved these changes
Oct 24, 2019
Member
|
Thanks again for your fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs which are locked in a transaction without an altered target,
still should to be unlocked on
git_transaction_commit.git_transaction_freealso unlocks refs but the moment of calling ofgit_transaction_freecannot be controlled in all situations.
Some binding libs call
git_transaction_freeon garbage collection or not at all if theapplication exits before and don't provide public access to
git_transaction_free.It is better to release locks as soon as possible.