Skip to content

Make type mismatch errors consistent#5359

Merged
ethomson merged 1 commit into
libgit2:masterfrom
tniessen:make-type-mismatch-errors-consistent
Jan 15, 2020
Merged

Make type mismatch errors consistent#5359
ethomson merged 1 commit into
libgit2:masterfrom
tniessen:make-type-mismatch-errors-consistent

Conversation

@tniessen

Copy link
Copy Markdown
Contributor

The same error message appears in other places with the word "the" included. API consumers in higher-level languages such as JavaScript (via nodegit) might consume these strings, so they should be consistent.

@ethomson

Copy link
Copy Markdown
Member

Good eye. Thanks for the fix.

@ethomson ethomson merged commit dea5ce3 into libgit2:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants