fix: keep analog example dist package-local#23
Merged
Conversation
❌ Deploy Preview for limitless-angular-sanity-example failed. Why did it fail? →
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Keeps the Analog Sanity blog example's generated files inside the example package instead of writing app build output into repository-level dist folders.
Closes N/A
What is the new behavior?
apps/analog-sanity-blog-example/dist.tsconfig.base.jsonpath plugins remain because they are still needed for workspace package imports.@/analog-sanity-blog-example/sanityremains because the dev worker used by e2e needs it at runtime.Does this PR introduce a breaking change?
Other information
Validated with:
pnpm --filter analog-sanity-blog-example buildpnpm --filter analog-sanity-blog-example exec ng buildpnpm turbo run e2e --filter=sanity-presentation-e2egit diff --checkBoth build entry points emit under
apps/analog-sanity-blog-example/dist; noapps/distor rootdist/apps/analog-sanity-blog-exampledirectory is produced.[Optional] What gif best describes this PR or how it makes you feel?