fix(release): align repository url for npm trust#58
Merged
Conversation
✅ Deploy Preview for limitless-angular-sanity-example canceled.
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
The trusted-publishing release job reached
npm publishbut npm returnedENEEDAUTH. npm trusted-publisher troubleshooting requires the packagerepository.urlto exactly match the GitHub repository, and@limitless-angular/sanitystill used the legacygit+https://...gitURL.Closes #
What is the new behavior?
packages/sanity/package.jsonnow uses the exact GitHub repository URL expected by npm trusted publishing:https://github.com/limitless-angular/limitless-angular.The release plan now carries the package repository URL, and publish preflight rejects repository metadata that cannot satisfy npm trusted publishing before the release job commits, tags, or attempts
npm publish.Does this PR introduce a breaking change?
Other information
Validation run locally:
pnpm --filter=@limitless-angular/release-tools testpnpm exec prettier --check packages/sanity/package.json tools/release/src/plan.mjs tools/release/src/preflight.mjs tools/release/src/preflight.test.mjs tools/release/src/plan.test.mjs tools/release/src/pipeline.test.mjs tools/release/README.mdgit diff --check[Optional] What gif best describes this PR or how it makes you feel?