Skip to content

fix(sanity): align dependency ownership#66

Merged
osnoser1 merged 1 commit into
mainfrom
osnoser1/dependency-handling
Jun 15, 2026
Merged

fix(sanity): align dependency ownership#66
osnoser1 merged 1 commit into
mainfrom
osnoser1/dependency-handling

Conversation

@osnoser1

@osnoser1 osnoser1 commented Jun 15, 2026

Copy link
Copy Markdown
Member

PR Checklist

Clarifies and enforces how the published @limitless-angular/sanity package owns peer dependencies versus bundled runtime dependencies.

Closes N/A

What is the new behavior?

  • Keeps Angular framework packages, RxJS, and @sanity/client as peer-owned integration dependencies.
  • Marks @angular/router as an optional peer because it is only needed by Visual Editing.
  • Moves Portable Text helper packages and @sanity/image-url to runtime dependencies and allows them in ng-package.json.
  • Updates package README install snippets to include the required Sanity client peer and the current Angular 18/19/20 support table.
  • Adds a manifest-policy test so future changes do not accidentally drift dependency ownership.
  • Keeps compatibility consumers resilient by reading dependency ranges from either dependencies or peerDependencies.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Validation:

  • pnpm --filter @limitless-angular/sanity build
  • pnpm --filter @limitless-angular/sanity lint
  • pnpm --filter @limitless-angular/sanity test
  • pnpm --filter @limitless-angular/angular-compat test
  • pnpm compat:assert
  • pnpm compat:pack
  • pnpm compat:artifact
  • pnpm compat:test
  • git diff --check

Notes:

  • compat:test passed generated Angular 18, 19, and 20 consumers against the packed tarball.
  • @sanity/client@6.28.0 exposes the ./csm and ./stega subpaths this package imports, but installing with v6 still produces peer warnings from transitive Sanity Visual Editing packages that prefer v7. That range is preserved here to avoid a breaking change.
  • pnpm peers check still reports pre-existing workspace/tooling peer warnings unrelated to this PR.

[Optional] What gif best describes this PR or how it makes you feel?

N/A

@netlify

netlify Bot commented Jun 15, 2026

Copy link
Copy Markdown

Deploy Preview for limitless-angular-sanity-example canceled.

Name Link
🔨 Latest commit d5fa414
🔍 Latest deploy log https://app.netlify.com/projects/limitless-angular-sanity-example/deploys/6a30100b1548dd0008b0b267

@pkg-pr-new

pkg-pr-new Bot commented Jun 15, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@limitless-angular/sanity@66

commit: d5fa414

@osnoser1 osnoser1 merged commit 912f43f into main Jun 15, 2026
18 checks passed
@osnoser1 osnoser1 deleted the osnoser1/dependency-handling branch June 15, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant