fix(sanity): align dependency ownership#66
Merged
Conversation
✅ Deploy Preview for limitless-angular-sanity-example canceled.
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Clarifies and enforces how the published
@limitless-angular/sanitypackage owns peer dependencies versus bundled runtime dependencies.Closes N/A
What is the new behavior?
@sanity/clientas peer-owned integration dependencies.@angular/routeras an optional peer because it is only needed by Visual Editing.@sanity/image-urlto runtime dependencies and allows them inng-package.json.dependenciesorpeerDependencies.Does this PR introduce a breaking change?
Other information
Validation:
pnpm --filter @limitless-angular/sanity buildpnpm --filter @limitless-angular/sanity lintpnpm --filter @limitless-angular/sanity testpnpm --filter @limitless-angular/angular-compat testpnpm compat:assertpnpm compat:packpnpm compat:artifactpnpm compat:testgit diff --checkNotes:
compat:testpassed generated Angular 18, 19, and 20 consumers against the packed tarball.@sanity/client@6.28.0exposes the./csmand./stegasubpaths this package imports, but installing with v6 still produces peer warnings from transitive Sanity Visual Editing packages that prefer v7. That range is preserved here to avoid a breaking change.pnpm peers checkstill reports pre-existing workspace/tooling peer warnings unrelated to this PR.[Optional] What gif best describes this PR or how it makes you feel?
N/A