Skip to content

Format errors.py with black#27

Merged
shimizust merged 2 commits into
linkedin-developers:mainfrom
nbro10:format-code
Jun 28, 2023
Merged

Format errors.py with black#27
shimizust merged 2 commits into
linkedin-developers:mainfrom
nbro10:format-code

Conversation

@nbro10

@nbro10 nbro10 commented Jun 26, 2023

Copy link
Copy Markdown
Contributor

If you run poetry run pre-commit run --all-files , you will get an error because linkedin_api/common/errors.py is not formatted correctly. This PR fixes that issue.

@shimizust shimizust left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the importlib metadata issue in 3.7

@nbro10

nbro10 commented Jun 28, 2023

Copy link
Copy Markdown
Contributor Author

@shimizust It would be great if we could merge this PR and #33 and release a new version of the library that contains these bug fixes because we have a pipeline that calls linkedin_api/clients/restli/utils/api.py using Python 3.7, and it fails because of this import issue. Thank you!

@shimizust

Copy link
Copy Markdown
Contributor

@nbro10 Yes, once #33 gets merged (there's a merge conflict) we can release a new version

@shimizust

Copy link
Copy Markdown
Contributor

@nbro10 Released v0.3.0 for you to try out. Thanks for the contributions!

@nbro10

nbro10 commented Jul 3, 2023

Copy link
Copy Markdown
Contributor Author

@shimizust Thanks! Our pipeline now doesn't fail after this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants