Skip to content

contrib: Add Surface Pro 10 suspend/resume fixes #2159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
djmulder wants to merge 1 commit into
base: master
Choose a base branch
from
Open

contrib: Add Surface Pro 10 suspend/resume fixes #2159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions contrib/surface-pro-10/99-surface-pro-10-wakeup.rules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Enable wakeup for Intel THC0 (Surface Pro 10 touchscreen/cover wake)
ACTION=="add", KERNEL=="0000:00:10.0", SUBSYSTEM=="pci", ATTR{power/wakeup}="enabled"
35 changes: 35 additions & 0 deletions contrib/surface-pro-10/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
# Surface Pro 10 (Meteor Lake) - Suspend/Resume Fixes

## Installation

Copy the udev rule for lid-open wake:

sudo cp 99-surface-pro-10-wakeup.rules /etc/udev/rules.d/
sudo udevadm control --reload-rules

Install the button fix service:

sudo cp surface-pro-10-buttons.service /etc/systemd/system/
sudo systemctl enable --now surface-pro-10-buttons.service

## Kernel Parameters

Add to your kernel command line (e.g. in /etc/default/grub):

i915.enable_psr2_sel_fetch=0

This fixes s2idle suspend/resume freezes caused by PSR2 selective fetch
failures on the Meteor Lake display pipeline.

## Issues Fixed

- s2idle suspend freeze (system never resumes after lid close)
- Power/volume buttons unreliable after boot (prevents wake)
- Lid open not waking system from suspend
- Kernel panic on resume caused by surface-quickspi hook unloading intel_thc

## Notes

The surface-quickspi sleep hook must NOT be used on Surface Pro 10 as it
causes an xhci kernel panic on resume by unloading intel_thc while USB
is active.
12 changes: 12 additions & 0 deletions contrib/surface-pro-10/surface-pro-10-buttons.service
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
[Unit]
Description=Reload soc_button_array to fix Surface Pro 10 buttons
After=multi-user.target

[Service]
Type=oneshot
ExecStart=/sbin/rmmod soc_button_array
ExecStartPost=/sbin/modprobe soc_button_array
RemainAfterExit=true

[Install]
WantedBy=multi-user.target