[libc++] LWG-4021 "mdspan::is_always_meow() should be noexcept", use LIBCPP_STATIC_ASSERT for noexcept strengthening#74254
Merged
philnik777 merged 4 commits intoDec 10, 2023
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while running libc++'s test suite with MSVC's STL.
mdspan::is_always_meow()should benoexcept" and implemented this in libc++'s product and test code.LIBCPP_STATIC_ASSERTto avoid issues withnoexceptstrengthening in MSVC's STL.mdspanconstruction/is_meow/strideandelements_viewiteratorbase() &&, and always strengthensbasic_stringbufswap.mdspan/properties.pass.cpp, this also upgrades runtimeasserts tostatic_asserts.asserttostatic_assertwhen inspecting thenoexceptness ofstd::ranges::iter_move. (These!noexcepttests weren't causing issues for MSVC's STL, so I didn't change them to be libc++-specific.)