Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

SNS: V2 tagging#13254

Merged
baermat merged 1 commit into
mainfrom
sns/v2-tagging
Oct 15, 2025
Merged

SNS: V2 tagging#13254
baermat merged 1 commit into
mainfrom
sns/v2-tagging

Conversation

@baermat

@baermat baermat commented Oct 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Motivation

Adds tagging api calls and enables tagging related tests. Tagging works exactly as in other services with the taggingService

closes PNX-77

Changes

  • add tag_resource, untag_resource, list_tags_for_resource
  • enable tests

@baermat baermat added semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Oct 13, 2025
@github-actions

github-actions Bot commented Oct 13, 2025 •
edited
Loading

Copy link
Copy Markdown

Test Results - Preflight, Unit

22 337 tests  +39   20 587 ✅ +32   16m 6s ⏱️ +19s
     1 suites ± 0    1 750 💤 + 7 
     1 files   ± 0        0 ❌ ± 0 

Results for commit ef8623e. ± Comparison against base commit 343d436.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Oct 13, 2025 •
edited
Loading

Copy link
Copy Markdown

Test Results - Alternative Providers

132 tests    13 ✅  25s ⏱️
  1 suites  119 💤
  1 files      0 ❌

Results for commit ef8623e.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Oct 13, 2025 •
edited
Loading

Copy link
Copy Markdown

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 33s ⏱️ +16s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit ef8623e. ± Comparison against base commit 343d436.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Oct 13, 2025 •
edited
Loading

Copy link
Copy Markdown

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   58m 53s ⏱️ - 1h 1m 25s
2 827 tests  - 1 988  2 714 ✅  - 1 764  113 💤  - 224  0 ❌ ±0 
2 829 runs   - 1 988  2 714 ✅  - 1 764  115 💤  - 224  0 ❌ ±0 

Results for commit ef8623e. ± Comparison against base commit 343d436.

This pull request removes 1989 and adds 1 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.s3.test_s3.TestS3 ‑ test_create_bucket_aws_global

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Oct 13, 2025 •
edited
Loading

Copy link
Copy Markdown

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   1h 29m 38s ⏱️
2 851 tests 2 741 ✅ 110 💤 0 ❌
2 857 runs  2 741 ✅ 116 💤 0 ❌

Results for commit ef8623e.

♻️ This comment has been updated with latest results.

@baermat baermat marked this pull request as ready for review October 13, 2025 10:27
@baermat baermat requested a review from bentsku as a code owner October 13, 2025 10:27
bentsku
bentsku approved these changes Oct 13, 2025
View reviewed changes

@bentsku bentsku left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! this is a nice addition 🚀 only have one nit around the naming of extract_tags that comes from the previous implementation and we could improve, but other than that we're good to go 👌 nice work!

Comment thread localstack-core/localstack/services/sns/v2/provider.py Outdated
Comment thread localstack-core/localstack/services/sns/v2/provider.py Outdated
@baermat baermat merged commit 7528267 into main Oct 15, 2025
10 of 11 checks passed
@baermat baermat deleted the sns/v2-tagging branch October 15, 2025 17:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bentsku bentsku bentsku approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@baermat @bentsku