This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Explicitly fix import order when regenerating ASF modules#13362
Merged
Conversation
purcell
added
semver: patch
alexrashed
approved these changes
Nov 10, 2025
alexrashed
left a comment
alexrashed
left a comment
Member
There was a problem hiding this comment.
Thanks for the follow up, to make sure that the make target really is self-sufficient!
Another option might be to use the existing make targets to change modified code, but the way you implemented it right now clearly only affects the module with the generated code. 💯
Contributor
Author
|
Yeah, I thought about a judicious |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 40m 30s ⏱️ Results for commit 0133c34. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Small adjustment needed to #13354, since when applying this to the pro version, I realised a further
ruff check --fixpass is required if themake asf-regeneratecommand is to be fully self-contained. Without this, the results of theasf-updateGitHub workflow would not pass the linter.Changes
Also run
ruff check --fix, as done inmake format.Tests
Related
#13354