This repository was archived by the owner on Mar 23, 2026. It is now read-only.
optimize config analytics event before sending#13744
Merged
Merged
Conversation
thrau
added
semver: patch
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 8m 53s ⏱️ Results for commit 6004422. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 41m 19s ⏱️ Results for commit 6004422. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In the
configanalytics event, we are sending config variables as dictionaries with all listed variables, even if their values are None. In our data backend, we actually discard all of those None values anyway, so there's no point in sending them.A quick analysis shows that we can reduce the overall size of this event category by an order of magnitude this way.
Changes
configanalytics payload now only sends config vars whose value are not NoneTests
We tested this manually in a session with @valentinarmo and @ackdav
Related