Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Fix: Clean Up from RGTA Migration#13835

Merged
aidehn merged 1 commit into
mainfrom
aidehn/fix/leftover-fixes-from-rgta-migration
Feb 25, 2026
Merged

Fix: Clean Up from RGTA Migration#13835
aidehn merged 1 commit into
mainfrom
aidehn/fix/leftover-fixes-from-rgta-migration

Conversation

@aidehn

@aidehn aidehn commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

Motivation + Changes

  • Fixes the comments addressed in this PR. This includes moving the get_route53_store util to Pro since it's not used in Community, updating the docstring for the Tags collection and updating the KMS get_custom_key_material and get_custom_key_id to return early.

@aidehn aidehn added this to the 4.14 milestone Feb 24, 2026
@aidehn aidehn added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Feb 24, 2026
@aidehn aidehn requested review from bentsku and removed request for giograno and k-a-il February 24, 2026 13:31
@github-actions

github-actions Bot commented Feb 24, 2026

Copy link
Copy Markdown

Test Results - Preflight, Unit

23 070 tests  ±0   21 179 ✅ ±0   6m 9s ⏱️ -45s
     1 suites ±0    1 891 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 1ffc65d. ± Comparison against base commit 7a74f41.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Feb 24, 2026

Copy link
Copy Markdown

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   2m 58s ⏱️ -6s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 1ffc65d. ± Comparison against base commit 7a74f41.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Feb 24, 2026

Copy link
Copy Markdown

Test Results (amd64) - Integration, Bootstrap

    5 files  ±0      5 suites  ±0   2h 40m 56s ⏱️ +38s
5 740 tests ±0  5 213 ✅ ±0  527 💤 ±0  0 ❌ ±0 
5 746 runs  ±0  5 213 ✅ ±0  533 💤 ±0  0 ❌ ±0 

Results for commit 1ffc65d. ± Comparison against base commit 7a74f41.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Feb 24, 2026

Copy link
Copy Markdown

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   2h 5m 16s ⏱️ + 3m 6s
5 335 tests ±0  4 964 ✅ ±0  371 💤 ±0  0 ❌ ±0 
5 337 runs  ±0  4 964 ✅ ±0  373 💤 ±0  0 ❌ ±0 

Results for commit 1ffc65d. ± Comparison against base commit 7a74f41.

♻️ This comment has been updated with latest results.

@bentsku bentsku left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the follow-up!

@aidehn aidehn force-pushed the aidehn/fix/leftover-fixes-from-rgta-migration branch from 7a43f88 to 1ffc65d Compare February 25, 2026 11:27
@aidehn aidehn merged commit 106e8b5 into main Feb 25, 2026
35 checks passed
@aidehn aidehn deleted the aidehn/fix/leftover-fixes-from-rgta-migration branch February 25, 2026 12:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants