This repository was archived by the owner on Mar 23, 2026. It is now read-only.
fix SQS json requests sent to query route#9634
Merged
Merged
Conversation
alexrashed
approved these changes
Nov 14, 2023
alexrashed
left a comment
Member
There was a problem hiding this comment.
Perfect, thanks so much for investigating on this weird behavior, fixing it, and writing a validated test for it! 🦸🏽
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As reported in #8267 (comment), it seems the PHP SDK still struggles to communicate with LocalStack.
After investigation, it showed that the PHP SDK is still sending the requests to the queue URL even though the specs are specifying that it should be against
/. Our router caught the request and assumed it was a Query API.Changes
Content-Typeheader isapplication/x-amz-json-1.0, raiseNotFoundin the route so that the handler chain can take of the requestTested with a PHP sample, it solves the issue now
Testing
To test the changes with the PHP SDK:
docker pull phpdocker run --rm -it php bashcurl -sS https://getcomposer.org/installer | php -- --install-dir=/usr/local/bin --filename=composerapt updateapt install zipcd /usr/src&mkdir app&cd appcomposer require aws/aws-sdk-phptest.php:export AWS_ACCESS_KEY_ID=testexport AWS_SECRET_ACCESS_KEY=testphp test.php