test(repository-json-schema): verify "not.anyOf" in model schema#3906
Merged
Conversation
Modify the tests for JsonSchemaOption "exclude" to verify that "not" + "anyOf" is used to forbid excluded properties in data. Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
3 tasks
nabdelgadir
approved these changes
Oct 10, 2019
jannyHou
approved these changes
Oct 10, 2019
jannyHou
left a comment
jannyHou
left a comment
Contributor
There was a problem hiding this comment.
LGTM 
Commented a question.
| description: {type: 'string'}, | ||
| }, | ||
| not: { | ||
| anyOf: [{required: ['id']}], |
Contributor
There was a problem hiding this comment.
a question: why the generated excluding schema doesn't have properties field like:
not: {
anyOf: [{properties: {id: {type: 'string'}}, required: ['id']}]
}?
Member
Author
There was a problem hiding this comment.
a question: why the generated excluding schema doesn't have
propertiesfield like:not: { anyOf: [{properties: {id: {type: 'string'}}, required: ['id']}] }
IDK 🤷♂
@nabdelgadir, you are the author of this schema, do you perhaps know the answer?
raymondfeng
approved these changes
Oct 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify the tests for JsonSchemaOption "exclude" to verify that"not" + "anyOf" is used to forbid excluded properties in data.
See the following discussion for background context: #3895 (comment)
The PR that introduced the tests I am modifying: #3297
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈