Minor Boolean expression simplification

K0zka · K0zka · commit d6a6e8dfa5d8 · 2014-02-09T19:05:28.000+01:00
Signed-off-by: Laszlo Hornyak &lt;laszlo.hornyak@gmail.com&gt;
diff --git a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
@@ -310,11 +310,7 @@ public boolean copyVolume(String srcPath, String destPath, String volumeName, in
             throw new InternalErrorException("volume:" + srcPath + " is not exits");
         }
         String result = Script.runSimpleBashScript("cp " + srcPath + " " + destPath + File.separator + volumeName, timeout);
-        if (result != null) {
-            return false;
-        } else {
-            return true;
-        }
+        return result == null;
     }
 
     public LibvirtStoragePoolDef getStoragePoolDef(Connect conn, StoragePool pool) throws LibvirtException {

Original file line number	Diff line number	Diff line change
`@@ -310,11 +310,7 @@ public boolean copyVolume(String srcPath, String destPath, String volumeName, in`
`310`	`310`	`throw new InternalErrorException("volume:" + srcPath + " is not exits");`
`311`	`311`	`}`
`312`	`312`	`String result = Script.runSimpleBashScript("cp " + srcPath + " " + destPath + File.separator + volumeName, timeout);`
`313`		`- if (result != null) {`
`314`		`- return false;`
`315`		`- } else {`
`316`		`- return true;`
`317`		`- }`
	`313`	`+ return result == null;`
`318`	`314`	`}`
`319`	`315`
`320`	`316`	`public LibvirtStoragePoolDef getStoragePoolDef(Connect conn, StoragePool pool) throws LibvirtException {`