Skip to content

Don't give required parameters a default#2

Merged
neilgarb merged 1 commit into
luno:masterfrom
neilgarb:required
Jun 14, 2018
Merged

Don't give required parameters a default#2
neilgarb merged 1 commit into
luno:masterfrom
neilgarb:required

Conversation

@neilgarb

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Jun 14, 2018

Copy link
Copy Markdown

Codecov Report

Merging #2 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##           master    #2   +/-   ##
====================================
  Coverage      60%   60%           
====================================
  Files           4     4           
  Lines         140   140           
====================================
  Hits           84    84           
  Misses         56    56
Impacted Files Coverage Δ
luno_python/client.py 35.89% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4edb06...2d94d9d. Read the comment docs.

@neilgarb neilgarb merged commit ae75333 into luno:master Jun 14, 2018
@neilgarb neilgarb deleted the required branch June 14, 2018 12:02
echarrod pushed a commit to echarrod/luno-python that referenced this pull request Mar 29, 2026
echarrod pushed a commit to echarrod/luno-python that referenced this pull request Mar 29, 2026
improved general exceptions to be more specific
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants