Adding troubleshooting guide for BOMs#112
Merged
Merged
Conversation
dmendelowitz
requested review from
Dtphelan1,
jafeltra,
julianxcarter and
mgramigna
as code owners
julianxcarter
requested changes
Apr 26, 2021
julianxcarter
left a comment
julianxcarter
left a comment
Contributor
There was a problem hiding this comment.
The here text looks good! I just had two minor comments.
julianxcarter
approved these changes
Apr 26, 2021
julianxcarter
left a comment
julianxcarter
left a comment
Contributor
There was a problem hiding this comment.
Looks great, thanks for handling that!
jafeltra
reviewed
Apr 26, 2021
jafeltra
left a comment
jafeltra
left a comment
Contributor
There was a problem hiding this comment.
I just had one really small comment. Let me know what you think.
Contributor
|
I think this might just need to be rebased again. I doubt there are any conflicts but I just want to make sure no README updates get lost! |
dmendelowitz
force-pushed
the
readme-bom-troubleshooting
branch
from
b83e2ed to
c6e8208
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added section to README informing users that byte order markers are handled for UTF-8 and UTF-16 but may cause issues in other encodings and how they can check for BOMs in their CSVs
Testing guidance
Read the new section of the README and make sure it is all correct and that I didn't leave anything out