Update config.schema.json for use with react-jsonschema-form; export …#143
Merged
Conversation
…JSON object from index.js
SenecaAnderson
requested review from
Dtphelan1,
dmendelowitz,
jafeltra,
julianxcarter and
mgramigna
jafeltra
reviewed
Jul 30, 2021
jafeltra
left a comment
jafeltra
left a comment
Contributor
There was a problem hiding this comment.
This looks good, I just had two really small comments!
| @@ -69,6 +69,8 @@ const { getConditionEntriesFromContext, getConditionsFromContext, getEncountersF | |||
| const { parsePatientIds } = require('./helpers/appUtils'); | |||
| const { getConfig, validateConfig } = require('./helpers/configUtils'); | |||
|
|
|||
Contributor
There was a problem hiding this comment.
This is incredibly small, but can we remove the blank line between the exports here? They should all stay grouped together.
| ] | ||
| }, | ||
| "tlsRejectUnauthorized": { | ||
| "title": "Reject Unauthorized Connections", |
Contributor
There was a problem hiding this comment.
I think I would have this title still include "TLS", so maybe just "TLS Reject Unauthorized Connections".
Contributor
Author
|
I have pushed the requested changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…JSON object from index.js
Summary
The schema for configuration files was updated to include titles for each field. The schema is now exported from index.js.
New behavior
index.js exports the schema. The schema now includes titles.
Code changes
Testing guidance
Add a console.log statement to print configSchema. Run extraction. The object will print.