Skip to content

Handle ROUTING_APP error response in onResponseTraceRoute #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ianmcorvidae merged 3 commits into from
Jun 12, 2026
+47 −0
Merged

Handle ROUTING_APP error response in onResponseTraceRoute #930

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0413d00
Handle ROUTING_APP error response in onResponseTraceRoute
NoctisSentinel Jun 3, 2026
c71d3df
Add unit test for onResponseTraceRoute ROUTING_APP error handling
NoctisSentinel Jun 4, 2026
953d012
Handle NONE errorReason in onResponseTraceRoute and add regression test
NoctisSentinel Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Handle ROUTING_APP error response in onResponseTraceRoute 
Previously, receiving a ROUTING_APP packet in response to a traceroute
would cause the function to attempt parsing it as a RouteDiscovery
payload, resulting in a crash or silent failure followed by a timeout.

This mirrors the error handling already present in onResponseTelemetry
and onResponseWaypoint, but displays the specific errorReason instead
of a hardcoded firmware version message, since traceroute is a
diagnostic tool where the exact failure reason is more valuable.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
  • Loading branch information
@NoctisSentinel @claude
NoctisSentinel and claude committed Jun 3, 2026
commit 0413d00825fea5e3aa2230278852bb2292bbb774
6 changes: 6 additions & 0 deletions meshtastic/mesh_interface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,6 +687,12 @@ def sendTraceRoute(

def onResponseTraceRoute(self, p: dict):
"""on response for trace route"""
if p["decoded"]["portnum"] == "ROUTING_APP":
error = p["decoded"]["routing"]["errorReason"]
print(f"Traceroute failed: {error}")
self._acknowledgment.receivedTraceRoute = True
return
Comment on lines +690 to +695

@NoctisSentinel NoctisSentinel Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the unit test, can you check again ?


UNK_SNR = -128 # Value representing unknown SNR

routeDiscovery = mesh_pb2.RouteDiscovery()
Expand Down