fix(dev-config): Use skipExistingInit to prevent overwriting existing oh-my-posh config#87
Open
shunkino wants to merge 1 commit into
Open
fix(dev-config): Use skipExistingInit to prevent overwriting existing oh-my-posh config#87shunkino wants to merge 1 commit into
shunkino wants to merge 1 commit into
Conversation
6a61b02 to
23ac5ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53
Issue
In
windows-dev-config/dev-config.winget, the config uses:When DSC is applied, it updates the existing
oh-my-poshinit line in$PROFILEto the declared command.That means a custom line like:
gets rewritten to:
Why this is a problem
Many users customize their prompt via
--config, and this is valid/manual user configuration. The rest of the profile remains untouched, but theoh-my-poshline is normalized and the custom theme/config is lost.Fix
Thanks to the upstream improvement, oh-my-posh DSC module now have a feature to skip the update when there's existing configuration.
With this, we can simply fix the issue like this: