fix(bidi): prevent prototype pollution in BiDi deserialization#41322
Merged
Conversation
Use Object.create(null) instead of {} for the result object in
deserializeBidiMapping to prevent a __proto__ key from remote BiDi
data from modifying Object.prototype.
yury-s
approved these changes
Jun 16, 2026
Contributor
Test results for "MCP"7341 passed, 1122 skipped Merge workflow run. |
Contributor
Test results for "tests 1"2 flaky39601 passed, 743 skipped Merge workflow run. |
Closed
Collaborator
|
@SebTardif please note that this PR got reverted due to #41341. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Object.create(null)instead of{}indeserializeBidiMappingto prevent a__proto__key from remote BiDi data from modifyingObject.prototypeIntroduced in #38587