Skip to content

fix(heft-sass-plugin): wire ignoreDeprecationsInDependencies to Sass quietDeps#5834

Draft
Copilot wants to merge 2 commits into
mainfrom
copilot/fix-ignore-deprecations-in-dependencies
Draft

fix(heft-sass-plugin): wire ignoreDeprecationsInDependencies to Sass quietDeps#5834
Copilot wants to merge 2 commits into
mainfrom
copilot/fix-ignore-deprecations-in-dependencies

Conversation

Copilot AI commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

ignoreDeprecationsInDependencies was declared in the JSON schema, ISassProcessorOptions, and README but was silently dropped — never read from config and never forwarded to the Sass compiler. Setting it to true passed validation and had no effect.

Changes

  • SassPlugin.ts: Add ignoreDeprecationsInDependencies?: boolean to ISassConfigurationJson; destructure it from the loaded config and pass it into ISassProcessorOptions
  • SassProcessor.ts: Destructure ignoreDeprecationsInDependencies from options; set quietDeps: ignoreDeprecationsInDependencies on _scssOptions alongside the existing silenceDeprecations

quietDeps and silenceDeprecations are independent Sass compiler options and compose correctly — quietDeps suppresses deprecation warnings from dependency stylesheets only, while silenceDeprecations globally suppresses specific deprecation codes.

// config/sass.json — now actually works
{
  "ignoreDeprecationsInDependencies": true
}

Copilot AI changed the title [WIP] Fix ignoreDeprecationsInDependencies to wire to Sass quietDeps fix(heft-sass-plugin): wire ignoreDeprecationsInDependencies to Sass quietDeps Jun 15, 2026
Copilot AI requested a review from iclanton June 15, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs triage

Development

Successfully merging this pull request may close these issues.

2 participants