fix: simplified map+flat#193949
Merged
Merged
Conversation
Contributor
|
Assigning to the using-new-JS-features-authority ;) |
Contributor
|
Generally this can be used but AFAIK know (and the last time we checked) it is significant slower |
Contributor
I might be mistaken and confuse it with @Connormiha Can you check with a simple test on https://jsbench.me |
Contributor
Author
Contributor
|
Thanks! I see Chrome more or less the same, Safari ~30% faster (using flatMap), and FF ~10% slower. Always a surprise but I'd say we take it |
jrieken
approved these changes
Oct 2, 2023
Tyriar
approved these changes
Oct 2, 2023
Alex0007
pushed a commit
to Alex0007/vscode
that referenced
this pull request
Oct 26, 2023
fix: simplified map+flat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did a little optimization .
map+flatcan be replaced by singleflatMap.