This repository was archived by the owner on Dec 23, 2021. It is now read-only.
Resizing "Enable preview mode" pictures in getting started#311
Merged
Conversation
vandyliu
requested review from
abmahdy,
adclements,
iennae,
isadorasophia,
markAtMicrosoft,
nasadigital,
sagarmanchanda and
smmatte
as code owners
vandyliu
changed the title
nasadigital
approved these changes
Apr 9, 2020
nasadigital
left a comment
nasadigital
left a comment
There was a problem hiding this comment.
Looks great!
Bit related, but I feel like there is too much bold text on the top:
Perhaps consider playing around with the styles at the top?
Contributor
Author
Definitely something we can look into next week. Don't have time this week for release ): |
xnkevinnguyen
approved these changes
Apr 9, 2020
xnkevinnguyen
left a comment
xnkevinnguyen
left a comment
Contributor
There was a problem hiding this comment.
LGTM!Nice touch of having a pic in getting stared
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Type of change
Please delete options that are not relevant.
Limitations:
Please describe limitations of this PR
Testing:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
npm run formatand passes the checks innpm run check