eng/build.ps1:1

• $filterString now contains multiple switches in a single argument string. If this variable is passed as a single argument to the test runner (common in PowerShell when building an args array), the runner will receive one argument containing spaces and may not parse -ignore-exit-code correctly. Prefer passing arguments as separate items (e.g., an args array with distinct --filter, filter value, and ignore-exit-code tokens) rather than concatenating multiple switches into one string.

[CmdletBinding(PositionalBinding = $false)]

eng/build.ps1:1

• The comment explains ignoring exit code 8 specifically for filtered runs, but this block also triggers when only $testParameters.Count -gt 0. That means a run with no filter (but with test parameters) could silently ignore ‘no tests found’, potentially masking misconfiguration. Consider applying the ignore-exit-code behavior only when $filters.Count -gt 0 (or splitting the condition so the ignore flag is added only for filtered runs).

[CmdletBinding(PositionalBinding = $false)]

eng/build.ps1:1

• The comment and behavior are about filtered runs not matching any tests, but the condition also triggers when only $testParameters are provided. This would ignore exit code 8 even without a filter, which can mask genuine misconfiguration (e.g., wrong test project selection). Consider appending -ignore-exit-code 8 only when $filters.Count -gt 0, and keep the $testParameters path separate.

[CmdletBinding(PositionalBinding = $false)]

eng/build.ps1:1

• $filterString now contains more than just filter arguments (it also includes an exit-code policy). To keep intent clear and avoid future accidental coupling, consider either renaming to something like a general additional-args variable, or splitting into separate variables (one for --filter ..., another for ignore-exit-code) that are concatenated where the final command line is built.

[CmdletBinding(PositionalBinding = $false)]

eng/build.ps1:1

• This block runs when either filters or test parameters are provided, but it always emits a --filter argument. If $testParameters.Count -gt 0 and $filters.Count -eq 0, this produces --filter \"\" ..., which can change behavior or fail the test invocation. Split the logic so --filter (and the -ignore-exit-code 8 workaround) is only added when $filters.Count -gt 0, or build the final argument list from independent pieces (filter args vs. test-parameter args).

[CmdletBinding(PositionalBinding = $false)]

eng/build.ps1:1

• $filterString now contains non-filter arguments (-ignore-exit-code 8), which makes the variable misleading and increases the risk of quoting/escaping issues if this string is reused/combined elsewhere. Consider keeping --filter ... in $filterString and appending -ignore-exit-code 8 as a separate argument at the call site (or via a dedicated variable like $ignoreExitCodeArgs). Also, if the intent is to only ignore exit code 8 for filtered runs, gate the addition on $filters.Count -gt 0 rather than the broader ($filters.Count -gt 0 -or $testParameters.Count -gt 0) branch.

[CmdletBinding(PositionalBinding = $false)]