Skip to content

[codex] Allow unsigned desktop draft releases #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DragonnZhang merged 1 commit into from
Jun 10, 2026
Merged

[codex] Allow unsigned desktop draft releases #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions .github/workflows/desktop-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,6 @@ on:
required: true
default: false
type: boolean
allow_unsigned_test_release:
description: "Allow unsigned macOS/Windows artifacts only for prerelease testing."
required: true
default: false
type: boolean
clobber:
description: "Replace same-named assets when uploading to an existing release."
required: true
Expand Down Expand Up @@ -290,8 +285,7 @@ jobs:
APPLE_APP_SPECIFIC_PASSWORD_SECRET: ${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }}
APPLE_ID_SECRET: ${{ secrets.APPLE_ID }}
APPLE_TEAM_ID_SECRET: ${{ secrets.APPLE_TEAM_ID }}
ALLOW_UNSIGNED_TEST_RELEASE: ${{ inputs.allow_unsigned_test_release }}
IS_PRERELEASE: ${{ inputs.prerelease }}
IS_DRAFT: ${{ inputs.draft }}
MAC_CSC_KEY_PASSWORD_SECRET: ${{ secrets.MAC_CSC_KEY_PASSWORD }}
MAC_CSC_LINK_SECRET: ${{ secrets.MAC_CSC_LINK }}
CSC_KEY_PASSWORD_SECRET: ${{ secrets.CSC_KEY_PASSWORD }}
Expand Down Expand Up @@ -325,7 +319,7 @@ jobs:
return 0
fi

if [ "$ALLOW_UNSIGNED_TEST_RELEASE" = "true" ] && [ "$IS_PRERELEASE" = "true" ]; then
if [ "$IS_DRAFT" = "true" ]; then
return 0
fi

Expand All @@ -352,7 +346,7 @@ jobs:
fi

if [ "$IS_DRY_RUN" = "false" ]; then
echo "::warning::Publishing an unsigned macOS prerelease for manual testing. Auto-update validation is not supported for this artifact."
echo "::warning::Publishing an unsigned macOS draft release for maintainer testing. Auto-update validation is not supported for this artifact."
fi

echo "CSC_IDENTITY_AUTO_DISCOVERY=false" >> "$GITHUB_ENV"
Expand All @@ -373,7 +367,7 @@ jobs:
fi

if [ "$IS_DRY_RUN" = "false" ]; then
echo "::warning::Publishing an unsigned Windows prerelease for manual testing. Windows may show Unknown Publisher / SmartScreen warnings."
echo "::warning::Publishing an unsigned Windows draft release for maintainer testing. Windows may show Unknown Publisher / SmartScreen warnings."
else
echo "Windows signing certificate is not configured; Windows dry-run artifacts will be unsigned."
fi
Expand Down