Skip to content

Allow unsigned Windows desktop release #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DragonnZhang merged 1 commit into from
Jun 16, 2026
Merged

Allow unsigned Windows desktop release #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions .github/workflows/desktop-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ jobs:
- name: Set up Node
uses: actions/setup-node@v6
with:
node-version-file: '.nvmrc'
node-version-file: ".nvmrc"

- name: Set up Bun
uses: oven-sh/setup-bun@v2
Expand Down Expand Up @@ -187,7 +187,7 @@ jobs:
- name: Set up Node
uses: actions/setup-node@v6
with:
node-version-file: '.nvmrc'
node-version-file: ".nvmrc"

- name: Check out Qwen Code source
if: ${{ inputs.qwen_code_source == 'source_branch' }}
Expand Down Expand Up @@ -371,15 +371,10 @@ jobs:
append_env "WIN_CSC_LINK" "$WIN_CSC_LINK_SECRET"
append_env "WIN_CSC_KEY_PASSWORD" "$WIN_CSC_KEY_PASSWORD_SECRET"
else
if ! allow_unsigned_artifacts; then
echo "::error::Published Windows desktop releases require WIN_CSC_LINK and WIN_CSC_KEY_PASSWORD."
exit 1
fi

if [ "$IS_DRY_RUN" = "false" ]; then
echo "::warning::Publishing an unsigned Windows draft release for maintainer testing. Windows may show Unknown Publisher / SmartScreen warnings."
else
if [ "$IS_DRY_RUN" = "true" ]; then
echo "Windows signing certificate is not configured; Windows dry-run artifacts will be unsigned."
else
echo "::warning::Windows signing certificate is not configured; published Windows desktop releases will be unsigned."
fi
fi
else
Expand Down