Skip to content

[codex] Preserve Windows shell for desktop release builds #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DragonnZhang merged 1 commit into from
Jun 8, 2026
Merged

[codex] Preserve Windows shell for desktop release builds #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/workflows/desktop-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,6 @@ jobs:
runs-on: ${{ matrix.os }}
timeout-minutes: 90
needs: release_metadata
defaults:
run:
shell: bash
env:
RELEASE_TAG: ${{ needs.release_metadata.outputs.tag }}
RELEASE_VERSION: ${{ needs.release_metadata.outputs.version }}
Expand Down Expand Up @@ -184,12 +181,13 @@ jobs:
run: bun install --frozen-lockfile

- name: Bump desktop version
run: bun run bump-desktop-version "$RELEASE_VERSION"
run: bun run bump-desktop-version "${{ needs.release_metadata.outputs.version }}"

- name: Confirm release version
run: bun run check-release-version --version "$RELEASE_VERSION"
run: bun run check-release-version --version "${{ needs.release_metadata.outputs.version }}"

- name: Configure optional signing secrets
shell: bash
env:
APPLE_APP_SPECIFIC_PASSWORD_SECRET: ${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }}
APPLE_ID_SECRET: ${{ secrets.APPLE_ID }}
Expand Down