Feat/useNewVerification#408
Draft
ahacker1-securesaml wants to merge 2 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Thank you for taking the time to create a PR to support this community-maintained project. We are all volunteers here, so features are only added by contributors like you. Please also be patient while the maintainers work to review your proposed changes for quality and efficacy.
Please include a summary of the change and, where appropriate, which issue is addressed.
Your description should also include a comment about the use-case for this change, including what systems you may be interfacing with that require this change. This will help future users know how this library is being used in the wild and how well supported it is.
If the change involves the SAML specification, please include a link to the relevant part(s) of the SAML specification. Doing so speeds up the review process and helps the maintainers make sure that this project remains spec-compliant. You might start here to find the part of the specification that relates to this PR.
Please include tests. Doing so will ensure that the changes made in this PR are not undone or otherwise corrupted by future changes.
Checklist: