Skip to content

buffer: improve allocation and from(arrayLike) performance #10443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mscdex wants to merge 2 commits into from
Closed

buffer: improve allocation and from(arrayLike) performance #10443

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6dba12
buffer: improve allocation performance
mscdex Dec 25, 2016
801493c
buffer: avoid 'in' operator
mscdex Dec 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
buffer: avoid 'in' operator 
This change results in ~50% improvement when creating a Buffer from
an array-like object.
  • Loading branch information
@mscdex
mscdex committed Dec 25, 2016
commit 801493cc98d35179a8113a15a9bddecd41c7c701
11 changes: 10 additions & 1 deletion benchmark/buffers/buffer-from.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ const bench = common.createBenchmark(main, {
'buffer',
'uint8array',
'string',
'string-base64'
'string-base64',
'object'
],
len: [10, 2048],
n: [1024]
Expand All @@ -25,6 +26,7 @@ function main(conf) {
const str = 'a'.repeat(len);
const buffer = Buffer.allocUnsafe(len);
const uint8array = new Uint8Array(len);
const obj = { length: null }; // Results in a new, empty Buffer

var i;

Expand Down Expand Up @@ -80,6 +82,13 @@ function main(conf) {
}
bench.end(n);
break;
case 'object':
bench.start();
for (i = 0; i < n * 1024; i++) {
Buffer.from(obj);
}
bench.end(n);
break;
default:
assert.fail(null, null, 'Should not get here');
}
Expand Down
2 changes: 1 addition & 1 deletion lib/buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ function fromObject(obj) {
}

if (obj) {
if ('length' in obj || isArrayBuffer(obj.buffer) ||
if (obj.length !== undefined || isArrayBuffer(obj.buffer) ||
isSharedArrayBuffer(obj.buffer)) {
if (typeof obj.length !== 'number' || obj.length !== obj.length) {
return new FastBuffer();
Expand Down