Skip to content

doc: 'constructor' implies use of new keyword #17364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CameronMoorehead wants to merge 3 commits into from
Closed

doc: 'constructor' implies use of new keyword #17364

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96c9f1d
doc: 'constructor' implies use of new keyword
CameronMoorehead Nov 28, 2017
acc507f
doc: square constructor name capitalized to Square
CameronMoorehead Nov 28, 2017
fb9af62
doc: my Square to mySquare
CameronMoorehead Nov 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: 'constructor' implies use of new keyword 
the square module is described as exporting a constructor,
which would mean it would need to be invoked with the
new keyword in bar.js after requiring it. Otherwise it's
technically a factory function, not a constructor.
  • Loading branch information
@CameronMoorehead
CameronMoorehead authored Nov 28, 2017
commit 96c9f1dd88234602ebc83f9a7e21510f15b8a087
2 changes: 1 addition & 1 deletion doc/api/modules.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ Below, `bar.js` makes use of the `square` module, which exports a constructor:

```js
const square = require('./square.js');
const mySquare = square(2);
const mySquare = new square(2);
console.log(`The area of my square is ${mySquare.area()}`);
```

Expand Down