Skip to content

test: add test for util.inspect#27906

Closed
Nievl wants to merge 1 commit into
nodejs:masterfrom
Nievl:util-inspect-depth
Closed

test: add test for util.inspect#27906
Nievl wants to merge 1 commit into
nodejs:masterfrom
Nievl:util-inspect-depth

Conversation

@Nievl

@Nievl Nievl commented May 26, 2019

Copy link
Copy Markdown
Contributor

add test case for util.inspect with 'depth' option set to 'null'
and with that has a custom inspect function attached

Checklist
  • [ x ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ x ] tests and/or benchmarks are included

add test case for util.inspect with 'depth' option set to 'null'
 and with that has a custom inspect function attached
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 26, 2019
@BridgeAR BridgeAR added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label May 26, 2019

@ryzokuken ryzokuken left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@gireeshpunathil gireeshpunathil added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 27, 2019
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@ZYSzys

ZYSzys commented May 28, 2019

Copy link
Copy Markdown
Member

Landed in 3b50bde 🎉

@ZYSzys ZYSzys closed this May 28, 2019
targos pushed a commit that referenced this pull request May 31, 2019
add test case for util.inspect with 'depth' option set to 'null'
 and with that has a custom inspect function attached

PR-URL: #27906
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@targos targos mentioned this pull request Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants