Skip to content

doc: make pull-request guide default branch agnostic #41299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 3 commits into from
Dec 31, 2021
Merged

doc: make pull-request guide default branch agnostic #41299

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a674c6f
doc: make pull-request guide default branch agnostic
aduh95 Dec 23, 2021
adb7ed3
Use `text` instead of `sh`
aduh95 Dec 26, 2021
bace3a8
Update doc/guides/contributing/pull-requests.md
aduh95 Dec 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update doc/guides/contributing/pull-requests.md 
Co-authored-by: Rich Trott <rtrott@gmail.com>
  • Loading branch information
@aduh95 @Trott
aduh95 and Trott authored Dec 26, 2021
commit bace3a8a90a3d25ca969eaef4113025c3225c9af
2 changes: 1 addition & 1 deletion doc/guides/contributing/pull-requests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ your pull request waiting longer than you expect, see the

When a collaborator lands your pull request, they will post
a comment to the pull request page mentioning the commit(s) it
landed as. GitHub may show the pull request as `Closed` at this
landed as. GitHub might show the pull request as `Closed` at this
point, but don't worry. If you look at the branch you raised your
pull request against, you should see a commit with your name on it.
Congratulations and thanks for your contribution!
Expand Down