Skip to content

util: move deprecated utils to runtime deprecation #50488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marco-ippolito wants to merge 18 commits into from
Closed

util: move deprecated utils to runtime deprecation #50488

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
5960c6f
util: runtime deprecation util._extend
marco-ippolito Oct 31, 2023
09e59f2
util: runtime deprecate util.isArray
marco-ippolito Oct 31, 2023
cc52b69
util: runtime deprecation util.isBoolean
marco-ippolito Oct 31, 2023
e0bd8b8
util: runtime deprecation util.isBuffer
marco-ippolito Oct 31, 2023
dca7282
util: runtime deprecate util.isDate
marco-ippolito Oct 31, 2023
f2d35a3
util: runtime deprecate util.isError
marco-ippolito Oct 31, 2023
1c1745b
util: runtime deprecate util.isFunction
marco-ippolito Oct 31, 2023
8d98dd0
util: runtime deprecate util.isNull
marco-ippolito Oct 31, 2023
b14723b
util: runtime deprecate util.isNullOrUndefined
marco-ippolito Oct 31, 2023
a00fdd9
util: runtime deprecate util.isNumber
marco-ippolito Oct 31, 2023
b2c09ce
util: runtime deprecate util.isObject
marco-ippolito Oct 31, 2023
58a1e25
util: runtime deprecate util.isPrimitive
marco-ippolito Oct 31, 2023
d1bc34b
util: runtime deprecate util.isRegExp
marco-ippolito Oct 31, 2023
fd492e1
util: runtime deprecate util.isString
marco-ippolito Oct 31, 2023
e8a7ae2
util: runtime deprecate util.isSymbol
marco-ippolito Oct 31, 2023
e067d7e
util: runtime deprecate util.isUndefined
marco-ippolito Oct 31, 2023
c5e63a1
util: runtime deprecate util.log
marco-ippolito Oct 31, 2023
6bed94f
doc: add migration paths for deprecated utils
marco-ippolito Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
util: runtime deprecate util.isPrimitive
  • Loading branch information
@marco-ippolito
marco-ippolito committed Nov 24, 2023
commit 58a1e2555dfb184922c71712a1656f8f8e5dc2e0
5 changes: 4 additions & 1 deletion doc/api/deprecations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1198,6 +1198,9 @@ The [`util.isObject()`][] API is deprecated.

<!-- YAML
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/50488
description: Runtime deprecation.
- version:
- v6.12.0
- v4.8.6
Expand All @@ -1210,7 +1213,7 @@ changes:
description: Documentation-only deprecation.
-->

Type: Documentation-only
Type: Runtime

The [`util.isPrimitive()`][] API is deprecated.

Expand Down
6 changes: 5 additions & 1 deletion lib/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,11 @@ module.exports = {
isFunction: deprecate(isFunction,
'The `util.isFunction` API is deprecated. Please use `typeof arg === "function"` instead.',
'DEP0049'),
isPrimitive: deprecate(isPrimitive, 'The `util.isPrimitive API is deprecated.', 'DEP0054'),
isPrimitive: deprecate(isPrimitive,
'The `util.isPrimitive` API is deprecated. ' +
'Please use `arg === null || ' +
'(typeof arg !== "object" && typeof arg !== "function")` instead.',
'DEP0054'),
log: deprecate(log, 'The `util.log API is deprecated.', 'DEP0059'),
Comment thread
marco-ippolito marked this conversation as resolved.
Outdated
promisify,
stripVTControlCharacters,
Expand Down