Skip to content

build: enable -DV8_ENABLE_CHECKS flag#61327

Merged
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
islandryu:61301
Jan 28, 2026
Merged

build: enable -DV8_ENABLE_CHECKS flag#61327
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
islandryu:61301

Conversation

@islandryu

@islandryu islandryu commented Jan 9, 2026

Copy link
Copy Markdown
Member

Fixes: #61301

I’ve made changes so that V8_ENABLE_CHECKS is enabled in debug builds.
In addition, I’ve fixed code that caused errors when V8_ENABLE_CHECKS is enabled.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig left review comments

@Renegade334 Renegade334 Renegade334 left review comments

@legendecas legendecas legendecas approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

gyp build process: configurations mishandling

5 participants

@islandryu @nodejs-github-bot @anonrig @legendecas @Renegade334