Add express <cstdlib> inclusion to format.h#63934
Open
aschwarzusp wants to merge 1 commit into
Open
Conversation
This is preventing nodejs to compile with LLVM's libcxx, missing definition to malloc. Reference: Gentoo bug 977376 at https://bugs.gentoo.org/977376
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dependencies
Author
Member
|
Can you upstream the changes to spdlog first, then get it into LIEF? After it goes out in a LIEF release you can run |
Author
|
It is fixed upstream since version 1.16.0, released on 11 Oct 2025 (gabime/spdlog@4418909) They fixed it by including , but later changed to <stdlib.h> on 28 Oct 2025 (gabime/spdlog@ea3e747) Maybe This could be solved by pulling spdlog from the system instead of bundling it in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is preventing nodejs to compile with LLVM's libcxx, missing definition to malloc.
Reference: Gentoo bug 977376 at https://bugs.gentoo.org/977376