Skip to content

test: remove common.PORT from http tests #7467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 2 commits into from
Closed

test: remove common.PORT from http tests #7467

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
515db4c
test: remove common.PORT from http tests
Trott Jun 29, 2016
a3ff272
squash: object shorthand nits
Trott Jun 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
squash: object shorthand nits
  • Loading branch information
@Trott
Trott committed Jun 29, 2016
commit a3ff272326843665836ab6ba8cda5e1fffb9b688
8 changes: 4 additions & 4 deletions test/parallel/test-http-client-keep-alive-release-before-finish.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ const server = http.createServer((req, res) => {
const port = server.address().port;

const post = http.request({
agent: agent,
agent,
method: 'POST',
port: port,
port,
}, common.mustCall((res) => {
res.resume();
}));
Expand All @@ -30,9 +30,9 @@ const server = http.createServer((req, res) => {
}, 100);

http.request({
agent: agent,
agent,
method: 'GET',
port: port,
port,
}, common.mustCall((res) => {
server.close();
res.connection.end();
Expand Down
8 changes: 4 additions & 4 deletions test/parallel/test-http-no-read-no-dump.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ const server = http.createServer((req, res) => {
const port = server.address().port;

const post = http.request({
agent: agent,
agent,
method: 'POST',
port: port,
port,
}, common.mustCall((res) => {
res.resume();

Expand All @@ -43,9 +43,9 @@ const server = http.createServer((req, res) => {
post.write('initial');

http.request({
agent: agent,
agent,
method: 'GET',
port: port,
port,
}, common.mustCall((res) => {
server.close();
res.connection.end();
Expand Down