This repository was archived by the owner on Apr 22, 2023. It is now read-only.
Fix: Debugger Interface Command Issue - RegEx#1144
Closed
siddMahen wants to merge 2 commits into
Closed
Conversation
added 2 commits
June 2, 2011 23:08
…ut non-valid commands, resulting in confusing behaviour.
…ut non-valid commands, resulting in confusing behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the debugger interface handles commands, (
_debugger.js), in functionhandleCommand(), it uses regex which accepts incorrect input. For example: (line 946/master)This incorrectly returns true if 'seige' or 'sigh' are input, because they begin with s, resulting in confusing debugger behaviour.
Changes:
Should return the correct response for both 's' and 'step'.